View Full Version : Broken Smilies
wade-w
10-09-2004, 11:57 PM
pzmeyers must be chuckling somewhere. For some reason, at least some of the smilies are not working. Some are, but many others are not. This just happened; they were working about 15 minutes ago.
Lauri D
10-10-2004, 12:02 AM
pzmeyers must be chuckling somewhere. For some reason, at least some of the smilies are not working. Some are, but many others are not. This just happened; they were working about 15 minutes ago.
I just noticed the same thing...
livius drusus
10-10-2004, 12:03 AM
I have no idea what's going on. They're all completely normal in the ACP. I'm trying not to lose my mind. It's not easy.
livius drusus
10-10-2004, 12:08 AM
Okay. Obviously making :/ a smilie makes the other two character ones freak out. No idea why but I have to go take a cold shower or something. That was truly horrible.
wade-w
10-10-2004, 12:31 AM
Okay. Obviously making :/ a smilie makes the other two character ones freak out. No idea why but I have to go take a cold shower or something. That was truly horrible.
I suspected as much.
Ymir's blood
10-10-2004, 05:47 AM
Okay. Obviously making :/ a smilie makes the other two character ones freak out. No idea why but I have to go take a cold shower or something. That was truly horrible.
I'm sorry.
:kickcan:
pescifish
10-10-2004, 07:20 AM
Hey look, I finally know what happened to the right nut! :kickcan:
Which smilies aren't working, or weren't if you've fixed it?
I played with this on the test forum and it seemed to be fine.
It may be possible to get this to work still if you play with the order - put :/ at the end, or the beginning.
Or maybe the problem is that / gets treated as a special character. Would :\ do?
livius drusus
10-10-2004, 03:20 PM
Which smilies aren't working, or weren't if you've fixed it?
All the two-character ones like :) :( :D
Would :\ do?
I don't know if it works for Ymir, but it doesn't make me lose my will to live, so that's a step up from the first attempt.
Still weird. Why couldn't I reproduce the problem on the test forum?
livius drusus
10-10-2004, 04:34 PM
I couldn't possibly say, Joe, but if it's any help this was the error :) generated:
www.freethought-forum.com/forum/images/smilies/smile2.gif" border="0" alt="" title="Smile" class="inlineimg" />
Ymir's blood
10-10-2004, 05:10 PM
Would :\ do?
I don't know if it works for Ymir, but it doesn't make me lose my will to live, so that's a step up from the first attempt.
That one is great. I tried making one yesterday but couldn't get the expression to work out.
livius drusus
10-10-2004, 05:14 PM
Oh. Sorry, Ymir. Joe originally wrote :\ then I set your smilie to that in the ACP and saw that it didn't cause the same problem the / caused yesterday so I kept it and now Joe's post has the smilie in it instead of the text.
Um... Was that in any way understandable?
viscousmemories
10-10-2004, 05:19 PM
I suspect the problem has something to do with the fact that a typical URL has ":/" in it. For example: http://www.blahblah.com
Ymir's blood
10-10-2004, 05:22 PM
Oh. Sorry, Ymir. Joe originally wrote :\ then I set your smilie to that in the ACP and saw that it didn't cause the same problem the / caused yesterday so I kept it and now Joe's post has the smilie in it instead of the text.Ah, I see. It uses the '\' instead of '/'
Um... Was that in any way understandable?
Took me a second, but yes.
I suspect the problem has something to do with the fact that a typical URL has ":/" in it. For example: http://www.blahblah.com
And all the smilies here have absolute paths whereas they don't (I think?) on the tester.
But then that should affect all smilies?
livius drusus
10-10-2004, 06:44 PM
But then that should affect all smilies?
Right. Why only the smilies with two-character replacetext and none of the ones with words?
I suspect the problem has something to do with the fact that a typical URL has ":/" in it. For example: http://www.blahblah.com
And all the smilies here have absolute paths whereas they don't (I think?) on the tester.
But then that should affect all smilies?
These results just in: any smilie (however long the subst text is) with an absolute path like http://www.freethinkersforum.com/vb301/images/smilies/baby.gif suffers the painful substitution. Smilies with absolute paths like /vb301/images/smilies/baby.gif don't. Liv - does that make any sense corresponding with the two-character issue?
So we could fix the code that handles smilie substitution, as if I knew where that was, or edit all the smilie paths :eek: :eek: (or not bother with : / as a substitution).
joe
viscousmemories
10-10-2004, 09:06 PM
The code that handles the smilie substitution is in /includes/functions_bbcodeparse.php.
But all the smilies here should have an absolute URL, so I'm still not sure why only some smilies would've been affected.
Both forms I listed are absolute, in path terms ... maybe some of them don't include the http://domain bit?
Stop press: if you order the smilies so : / is the first, the problem is avoided (displayorder 1 in the first category - oh - that's not so desirable). Anyway, this explains why only some smilies would be affected.
viscousmemories
10-11-2004, 07:17 PM
Both forms I listed are absolute, in path terms ... maybe some of them don't include the http://domain bit?
Yeah that's the bit that makes it a URL and not a path. :P
This is how I use the terms:
Relative URL: /images/smilies/smile.gif
Absolute URL: http://www.freethought-forum.com/forum/images/smilies/smile.gif
Path: /forum/images/smilies/smile.gif
Absolute path: /server/root/path/public_html/forum/images/smilies/smile.gif
vBulletin® v3.7.2, Copyright ©2000-2008, Jelsoft Enterprises Ltd.