Haven’t seen Solo, but I thought R1 was by far a better film by most measures than TFW, although TFW was more popcorn-munchingly entertaining. So for me it’s really between Last Jedi and R1 for the top this-gen Star Wars film. I wasn’t blown away by any of them, but the surprises in TLJ were sorely needed at this stage of the franchise.
I now get why they never bothered to develop Snoak as a character, or even hint at his origins or why we should give a shit about him. But the red herring twist would’ve worked a helluva lot better if the Snoak plot thread had been ... an actual plot thread.